Update gradients module to stop mutating operators in-place #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-36756] |
Codecov Report
@@ Coverage Diff @@
## master #4220 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 351 351
Lines 32058 32111 +53
=======================================
+ Hits 31991 32044 +53
Misses 67 67
|
|
Will open for review after running benchmarks |
|
Ran an optimization workflow on a circuit with
|
mudit2812
commented
Jul 4, 2023
timmysilv
reviewed
Jul 7, 2023
Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
* Remove statevector support for qinfo functions * remove unused funcs * Fix some tests * pylint * more pylint * Remove unnecessary log * Changelog and deprecations entry * trigger ci
* rename all legacy test files to match pylint pattern * pylint all tests in CI and pre-commit * lint legacy/qnn/conftest * remove the custom pylint test handling * run black before pylint * changelog --------- Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
* use bind_new_parameters * pylint * remove batching in measurements and add tests * More coverage issues * Add uncopied tests * Helper function * pylint * Make tape._ops public * use private methods * pylint * Add more docs to split_operations * pylint
* update in docs * update changelog * Test warning is raised * update default gaussian device * update tests * update more tests * fix legacy tests * Specify v0.33 removal in docstring * Render X and P in docs * move deprecation warning in docstring * fix sphinx linking * add warning box
* Support wire labels in qinfo transforms * changelog * pylint and update test * add bugfix entry
* deprecate the old return system * deprecate the mode kwarg for QNode * changelog * PR feedback * update notice to avoid wrongly suggesting action needed * update docstrings, docs and warnings * add link to qnode returns doc * change the mode warning depending on return system active * also add disclaimer to docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In-place mutation of operators is being removed.
Description of the Change:
generate_shifted_tapesandgenerate_multishifted_tapesto stop mutating operators in-place and usebind_new_parametersinstead.Benefits:
This change impacts
parameter-shift,finite-diff, andspsagrad methods, which see comparable or better performance after removing in-place mutation.Possible Drawbacks:
Related GitHub Issues: